Skip to content

Update pre-commit linting checks#51

Merged
IFenton merged 9 commits intomainfrom
fix-linting
Aug 12, 2025
Merged

Update pre-commit linting checks#51
IFenton merged 9 commits intomainfrom
fix-linting

Conversation

@jemrobinson
Copy link
Copy Markdown
Member

@jemrobinson jemrobinson commented Aug 8, 2025

Fix pre-commit checks so that they apply to test folder too.

This requires changing some names of classes in the data/ folder which are (a) currently duplicated and (b) confusing the import sorter which thinks lightning and anemoi imports are part of ice_station_zebra.

  • data.anemoi moved to data_processors
  • data.lightning moved to data_loaders

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 8, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  ice_station_zebra
  types.py
  ice_station_zebra/cli
  main.py
  ice_station_zebra/data_loaders
  combined_dataset.py
  zebra_dataset.py
  ice_station_zebra/data_processors
  cli.py 20-23, 30-33
  zebra_data_processor.py
  zebra_data_processor_factory.py 14-21
  ice_station_zebra/evaluation
  evaluator.py
  ice_station_zebra/evaluation/callbacks
  plotting_callback.py 6-12
  ice_station_zebra/models
  encode_process_decode.py
  ice_station_zebra/models/decoders
  naive_latent_space_decoder.py 4-8
  ice_station_zebra/models/encoders
  base_encoder.py
  naive_latent_space_encoder.py
  ice_station_zebra/models/processors
  null.py 1-3
  unet.py 1-7
  ice_station_zebra/training
  trainer.py
Project Total  

This report was generated by python-coverage-comment-action

@jemrobinson jemrobinson changed the title Update pre-commit linting checks [WIP] Update pre-commit linting checks Aug 8, 2025
@jemrobinson jemrobinson marked this pull request as draft August 8, 2025 09:53
@jemrobinson jemrobinson changed the title [WIP] Update pre-commit linting checks Update pre-commit linting checks Aug 12, 2025
@jemrobinson jemrobinson marked this pull request as ready for review August 12, 2025 12:44
@jemrobinson jemrobinson requested a review from IFenton August 12, 2025 12:48
Copy link
Copy Markdown
Contributor

@IFenton IFenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IFenton IFenton merged commit 4904f03 into main Aug 12, 2025
3 checks passed
@IFenton IFenton deleted the fix-linting branch August 12, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants